This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Manifest diff as a PR comment for AzDO #1455
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmiodice I'm unable to request a review from you for some reason, but feel free to give any feedback here, I followed your template for Gitlab :) |
yradsmikham
approved these changes
Mar 10, 2021
Hey! I'm not a maintainer for this project so I won't be able to give a formal review on this. Looks like you got some feedback from the maintaining team, though. Happy to help if I can! |
|
It would be good too see a larger diff so we can see what the user experience is like for large yaml diffs and (additions/subtraction) |
|
Based on discussion with @andrebriggs, converting this to a draft and after testing with larger diffs, we will re-open this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-qto silence the wget output which was taking up 90% of the output in logs, making it difficult to focus on the important logs generated by the scriptsRelated to microsoft/spektate#155